Skip to content

Fix UB in repr(packed) tests #40373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2017
Merged

Fix UB in repr(packed) tests #40373

merged 1 commit into from
Mar 12, 2017

Conversation

@TimNN
Copy link
Contributor

@TimNN TimNN commented Mar 8, 2017 •
edited
Loading

r? @arielb1

cc #37609 and #27060

@TimNN
Copy link
Contributor Author

TimNN commented Mar 8, 2017

Actually, this is still no UB free I think -- as far as I can tell the initialisation of the fixed size array containing a packed struct does generate aligned loads, which is probably a bug in rustc?

@arielb1
Copy link
Contributor

arielb1 commented Mar 8, 2017

Yup there's a bug in loading/storing fields of pairs. I'll fix that tomorrow.

@nrc
Copy link
Member

nrc commented Mar 9, 2017

r? @arielb1

arielb1 added a commit to arielb1/rust that referenced this pull request Mar 9, 2017
@arielb1
emit !align attributes on stores of operand pairs
14e9313 
cc rust-lang#40373
@arielb1 arielb1 mentioned this pull request Mar 9, 2017
Merged
@arielb1
Copy link
Contributor

arielb1 commented Mar 9, 2017

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 9, 2017

📌 Commit 79a7ee8 has been approved by arielb1

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 9, 2017
Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1
b933fc6 
Fix UB in repr(packed) tests

r? @arielb1

cc rust-lang#37609 and rust-lang#27060
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 9, 2017
Rollup merge of rust-lang#40385 - arielb1:packed-again, r=eddyb
0f9c735 
emit !align attributes on stores of operand pairs

This avoids another case of missing-align UB. cc rust-lang#40373

r? @eddyb
@arielb1 arielb1 mentioned this pull request Mar 9, 2017
Closed
@arielb1 arielb1 mentioned this pull request Mar 10, 2017
Closed
@arielb1 arielb1 mentioned this pull request Mar 10, 2017
Closed
@arielb1 arielb1 mentioned this pull request Mar 10, 2017
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
@alexcrichton
Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1
bb558d1 
Fix UB in repr(packed) tests

r? @arielb1

cc rust-lang#37609 and rust-lang#27060
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
@alexcrichton
Rollup merge of rust-lang#40385 - arielb1:packed-again, r=eddyb
98f0197 
emit !align attributes on stores of operand pairs

This avoids another case of missing-align UB. cc rust-lang#40373

r? @eddyb
@alexcrichton alexcrichton mentioned this pull request Mar 10, 2017
Closed
alexcrichton pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
@alexcrichton
Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1
b7b2543 
Fix UB in repr(packed) tests

r? @arielb1

cc rust-lang#37609 and rust-lang#27060
alexcrichton pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
@alexcrichton
Rollup merge of rust-lang#40385 - arielb1:packed-again, r=eddyb
f2e0220 
emit !align attributes on stores of operand pairs

This avoids another case of missing-align UB. cc rust-lang#40373

r? @eddyb
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
@alexcrichton
Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1
01aaaec 
Fix UB in repr(packed) tests

r? @arielb1

cc rust-lang#37609 and rust-lang#27060
@alexcrichton alexcrichton mentioned this pull request Mar 10, 2017
Closed
@arielb1 arielb1 mentioned this pull request Mar 10, 2017
Closed
@alexcrichton alexcrichton mentioned this pull request Mar 10, 2017
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
@alexcrichton
Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1
9b97a83 
Fix UB in repr(packed) tests

r? @arielb1

cc rust-lang#37609 and rust-lang#27060
bors added a commit that referenced this pull request Mar 11, 2017
@bors
Auto merge of #40432 - alexcrichton:rollup, r=alexcrichton
764c006 
Rollup of 38 pull requests

- Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424
- Failed merges: #40220, #40329, #40426
bors added a commit that referenced this pull request Mar 11, 2017
@bors
Auto merge of #40432 - alexcrichton:rollup, r=alexcrichton
1727b23 
Rollup of 38 pull requests

- Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424
- Failed merges: #40220, #40329, #40426
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 11, 2017
Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1
7dd28e2 
Fix UB in repr(packed) tests

r? @arielb1

cc rust-lang#37609 and rust-lang#27060
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 11, 2017
Rollup merge of rust-lang#40385 - arielb1:packed-again, r=eddyb
d0531e9 
emit !align attributes on stores of operand pairs

This avoids another case of missing-align UB. cc rust-lang#40373

r? @eddyb
@arielb1 arielb1 mentioned this pull request Mar 11, 2017
Closed
bors added a commit that referenced this pull request Mar 11, 2017
@bors
Auto merge of #40440 - arielb1:rollup, r=arielb1
9ca8831 
Rollup of 13 pull requests

- Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40367, #40372, #40373, #40385, #40400, #40404, #40431
- Failed merges:
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 11, 2017
Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1
d75b9ad 
Fix UB in repr(packed) tests

r? @arielb1

cc rust-lang#37609 and rust-lang#27060
@arielb1 arielb1 mentioned this pull request Mar 11, 2017
Merged
@TimNN TimNN mentioned this pull request Mar 11, 2017
Closed
bors added a commit that referenced this pull request Mar 12, 2017
@bors
Auto merge of #40446 - arielb1:rollup, r=alexcrichton
744e696 
Rollup of 12 pull requests

- Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40372, #40373, #40400, #40404, #40419, #40431
- Failed merges:
@bors bors merged commit 79a7ee8 into rust-lang:master Mar 12, 2017
arielb1 added a commit to arielb1/rust that referenced this pull request Mar 13, 2017
@arielb1
emit !align attributes on stores of operand pairs
32c9893 
cc rust-lang#40373
bors added a commit that referenced this pull request Mar 13, 2017
@bors
Auto merge of #40385 - arielb1:packed-again, r=eddyb
ddc1708 
emit !align attributes on stores of operand pairs

This avoids another case of missing-align UB. cc #40373

r? @eddyb
@shepmaster shepmaster mentioned this pull request Mar 14, 2017
Closed
23 tasks
@TimNN TimNN deleted the test-ub-packed branch April 7, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1 arielb1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TimNN @arielb1 @nrc @bors